Use Flink 2.0 for load tests#38279
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the configuration for Flink load tests to utilize newer versions of both Dataproc and Flink. By upgrading these dependencies, the load testing environment will reflect more current software stacks, ensuring compatibility and leveraging improvements from the latest releases for more relevant performance evaluations. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Tests passed:
failed twice:
|
|
Thanks @stankiewicz. FYI There is one test currently failing (LoadTests Go Combine Flink Batch) I didn't dig into it. All tests need to be on same Flink version because they use a staged flink_job_server_container, that is published separately. We need to figure out this one or disable this test at the moment before merging this change. |
|
Let me merge this one and disable the single failed test at this moment. We need to get rid of 1.17/1.18 and support 2.1 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the default Dataproc version to 3.0-debian and updates the example Flink download URL to Flink 2.0.1 in the flink_cluster.sh script. A review comment correctly points out that Flink 2.0 binaries no longer include the -bin-scala_2.12 suffix, and suggests updating the URL to avoid a 404 error.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| # JOB_SERVER_IMAGE=gcr.io/<IMAGE_REPOSITORY>/job-server-flink:latest \ | ||
| # ARTIFACTS_DIR=gs://<bucket-for-artifacts> \ | ||
| # FLINK_DOWNLOAD_URL=https://archive.apache.org/dist/flink/flink-1.17.0/flink-1.17.0-bin-scala_2.12.tgz \ | ||
| # FLINK_DOWNLOAD_URL=https://archive.apache.org/dist/flink/flink-2.0.1/flink-2.0.1-bin-scala_2.12.tgz \ |
There was a problem hiding this comment.
In Flink 2.0, Scala has been completely decoupled from the Flink runtime and distribution (FLIP-323 / FLIP-441). As a result, the Flink 2.0 distribution binaries no longer include the -bin-scala_2.12 suffix in their filenames. Please update the URL to use the Scala-free binary distribution name to avoid a 404 error.
| # FLINK_DOWNLOAD_URL=https://archive.apache.org/dist/flink/flink-2.0.1/flink-2.0.1-bin-scala_2.12.tgz \ | |
| # FLINK_DOWNLOAD_URL=https://archive.apache.org/dist/flink/flink-2.0.1/flink-2.0.1-bin.tgz \ |
|
It appears since last run, Go CoGBK and Go GBK batch is failing |
2 participants
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.